OSS/podman
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(policy): disable intervention suppression for demo

Browse Source 
Dismissing one collision permanently silenced all future ones: the
dismissal gate (priorOutcome.accepted === false) plus loose file/vector
recall meant one README discard muted every later README clash. The
per-pod cooldown additionally hid consecutive conflicts for 3 min.

shouldIntervene now only filters `info` severity — Accept/Dismiss still
record outcomes but no longer gate whether a collision surfaces. The
same-collision single-shot dedupe (activeConflicts in PodmanAgent.handle)
still prevents repeat spam, so removing the cooldown is safe.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LuV8W8oNYRsDWKoqK8Mkqc
This commit is contained in:
Ramis
2026-06-28 10:12:51 -07:00
parent 65764f0a1c
commit 06098f3c4e
1 changed files with 16 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/memory/policy.ts
+16 -26
View File
@@ -1,32 +1,22 @@
import type { Collision, SuggestedActionKind } from '@podman/shared'; import type { Collision, SuggestedActionKind } from '@podman/shared';
import type { RecalledCollision } from './vectors.js'; import type { RecalledCollision } from './vectors.js';
const lastNudgeByPod = new Map<string, number>(); /**
* Policy gate — suppression fully disabled for the demo.
function cooldownMs(): number { *
return Number(process.env.NUDGE_COOLDOWN_MS ?? '180000'); * Every real collision surfaces an intervention. Accept/Dismiss are still
} * recorded as outcomes but carry NO gating meaning: dismissing one collision
* never silences future ones, and there is no per-pod cooldown throttling
/** Policy gate: combines severity, exact recall outcomes, and per-pod cooldown. */ * consecutive conflicts. The only filter is severity: `info` collisions are
export function shouldIntervene(collision: Collision, prior: RecalledCollision | null): boolean { * informational, not actionable, so they don't nudge. The same-collision
if (collision.severity === 'info') return false; * single-shot dedupe lives in `PodmanAgent.handle` (activeConflicts), so
* removing the cooldown does not cause repeat spam of an unresolved collision.
const priorOutcome = prior?.priorOutcome; *
// Suppress when the identical prior was dismissed (accepted === false). The * (Prior dismissal-based suppression over-generalized: one README discard
// former `&& !priorOutcome.wasRealCollision` term was dead code: outcomes are * permanently muted all README clashes via loose file/vector recall.)
// recorded with wasRealCollision hardcoded true, so the gate never fired and */
// the 85 real dismissals in Atlas were ignored. Dismissals are the negative export function shouldIntervene(collision: Collision, _prior: RecalledCollision | null): boolean {
// signal per continual-learning/policy.md:41 + spec.md:163. (RSI Step 1) return collision.severity !== 'info';
if (priorOutcome && !priorOutcome.accepted) return false;
const cooldown = cooldownMs();
const last = lastNudgeByPod.get(collision.podId) ?? 0;
if (cooldown > 0 && Date.now() - last < cooldown) {
return false;
}
lastNudgeByPod.set(collision.podId, Date.now());
return true;
} }
/** Preferred action selection based on collision severity and prior accepted actions. */ /** Preferred action selection based on collision severity and prior accepted actions. */