OSS/podman
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(continual-learning): derive wasRealCollision from git overlap (RSI step 3)

Browse Source 
Backend becomes authoritative for the verifier signal. recordOutcome now
overrides the client-supplied wasRealCollision with deriveWasRealCollision():
a flagged collision counts as REAL only if BOTH named engineers currently have
the collided file in their git changedFiles (getGitStates, 120s freshness TTL).
Conservative false when the collision is orphaned/missing or git state is
stale. Restores the (accepted x wasReal) 2x2 the spec assumes instead of the
hardcoded 107/107 true.

frontend/useInterventions.ts stops sending a hardcoded `true` (now a
backend-overridden placeholder). Spec: continual-learning/spec.md:98-108,
policy.md:35-42. backend+frontend typecheck + eslint pass. PLAN.md P0.5 rung 3
added.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
sb-iam
2026-06-28 07:47:53 -05:00
parent 0d69f82139
commit d9776452b2
3 changed files with 55 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/PLAN.md
+15 -5
View File
@@ -509,11 +509,21 @@ no schema change. Owner: RSI track. Independent of the MongoDB-cleanup handoff.
- Spec: `docs/continual-learning/policy.md:62-63` (prefer prior accepted
kind), `plan.md:66` (second similar event behaves differently).
Follow-ups (separate rungs, not in this change): Step 3 derive
`wasRealCollision` from git overlap; Step 4-5 `strategy_versions` +
Gemini-proposed `LearningProposal` slice; seed a clean demo pod with a repeated
dismissed signature (the historic 85 dismissals are orphaned — `collisionId`
resolves to no collision — so they cannot drive the demo verifier).
3. **Step 3 - derive `wasRealCollision` from git overlap (backend-authoritative)** ✅
- `backend/src/memory/store.ts` `recordOutcome` now overrides the
client-supplied `wasRealCollision` with `deriveWasRealCollision()`: a
collision is real only if BOTH named engineers currently have the collided
file in their git `changedFiles` (`getGitStates`, 120s freshness TTL).
Conservative `false` when orphaned/stale. `frontend/.../useInterventions.ts`
stops sending a hardcoded `true` (now a backend-overridden placeholder).
- Restores the (accepted × wasReal) 2×2 the spec assumes.
- Spec: `docs/continual-learning/spec.md:98-108`, `policy.md:35-42`.
Follow-ups (separate rungs, not in this change): Step 4-5 `strategy_versions` +
Gemini-proposed `LearningProposal` slice; Step 6 durable `owns` write; seed a
clean demo pod with a repeated dismissed signature (the historic dismissals are
orphaned — `collisionId` resolves to no collision — so they cannot drive the
demo verifier).
### P1 - polish the money moment