Each was raised by a reviewer and then survived an independent attempt to
refute it. The four that mattered most:
- A third of the starter library was invisible. Three templates authored
`fields` shapes no renderer read — decisions, blockingSet, checks,
steps and the rest — so about forty records rendered as no DOM at all,
in the library and again on the engagement that instantiated them.
Nothing failed: a renderer returns null for a key set it does not
recognise, and a header-plus-body page looks like a template written
that way. FieldsView now reads every key the seeds carry.
- "Add a framework" opened a picker that could never match, because the
dialog was seeded with both the forced kind and the deal's stage, and
qualification serves only the qualification stage. The stage is now
dropped when MOTION_KIND_STAGES says the pair is incoherent.
- Piggy reported the promotion count as an exact figure capped at 8,
against a tile showing the true count beside it. It is now counted in
SQL, and all three motion tools carry a ResultScope whose denominator
is shared lineages — never rows, never private drafts.
- No Motion test went through createApp, so the whole feature could be
unmounted with a green suite. That is the AGENTS.md §5 trap that
already cost this project read-guards.ts and learn.ts.
Also: both sides of the instantiate/edit race now lock, so a template
cannot be rewritten under an artefact that has copied it; concurrent
engagement opens queue on the deal row and get the 409 the handler
already promised rather than a 500; latestScore uses DISTINCT ON instead
of losing engagements past a 200-row cap; the migration adds the
scored_by_user_id foreign key the schema declares; and the demo clear
refunds usage_count for engagements it reaches by cascade, which
otherwise left starter templates permanently un-editable.
Verified on a fresh database: 16 migrations apply and re-apply as a
no-op, both seeds idempotent, usage_count back to zero after --clear.
564 unit tests pass. Every Motion route measures zero horizontal
overflow at 393 and 1440 in both themes, and all twelve seeded field
trees are asserted onto the screen by scripts/motion-fields-check.mjs.
One thing left open deliberately: the shipped qualification scorecard's
five bands and MOTION_BANDS' four are calibrated differently. The
framework's table is now titled as its own guidance rather than the
product's verdict, which removes the contradiction on screen. Making the
framework's calibration authoritative over the persisted band column is
a product decision nobody has made.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Measured against a running server: five of the eleven Motion `:id` routes
answered `500 {"error":"Internal error"}` for an id like `nope`, and the
other six only answered 400 because their body schema happened to be
checked first — a valid body would have reached the same cast.
Nothing was wrong with the not-found handling. That branch was never
reached: every id column is a `uuid`, so Postgres refuses the parameter
with `22P02` several layers below it, and the error is not a
MutationError so it leaves as a 500.
404 rather than 400, because a 400 for a malformed id and a 404 for a
well-formed one tells anyone probing which of their guesses are the right
shape — and this feature already routes "somebody else's private draft"
through the same 404 so that no answer distinguishes the reasons a row is
not yours to see.
Also adds the AGENTS.md §5 393px check for the five Motion routes, which
scripts/screenshots.mjs does not photograph. All five measure zero
horizontal overflow at 393 and 1440, light and dark.
The same 500 is reachable on /api/accounts/:id and /api/contracts/:id,
which predates this branch and is left alone here.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The ledger answers which contracted capacity is sold, to whom, at what
margin. It says nothing about the motion — the repeatable practice that
turns a customer conversation into a scoped deployment, and turns that
deployment into something the next one reuses.
Motion is deliberately not a parallel entity tree. DEMAND_STAGES already
is the motion, so Motion binds reusable artefacts to the stages of a
demand deal that already exists: an engagement hangs off one deal,
cascade deleted, one per deal by unique constraint.
Nine closed kinds, each declaring which stages it serves, and a starter
library of twelve templates covering all eight open stages.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
karti