Files
pig/apps/api/src/routes/facts.ts
T
karti 13dec6b4b8
CI / verify (push) Successful in 3m45s
CI / publish (push) Has been skipped
Rebuild the shell, add Calendar and Learn, and govern reads
Seven parallel agents and an adversarial verification pass. The three things
worth knowing before reading the diff:

RBAC WAS ALREADY BUILT. docs/build-plan.md marks F2 and F3 outstanding and is
stale — packages/core/src/permissions.ts and lib/mutation.ts shipped long ago.
So this does not rebuild them; it closes the gaps an audit found. The big one
is that reads were entirely ungoverned: every GET was "any authenticated
member", so a junior demand rep and a research contractor could both pull
per-block supplier cost and break-even prices from /api/capacity/margin, and
every contract's negotiated terms. For a company whose margin is the business,
that was the hole that mattered. Adds book:read / economics:read / team:read,
a readGuard middleware, and a `viewer` role below member.

THE BUTTON AND THE 403 DISAGREED — the exact thing F3 said must never happen.
Contracts.tsx never called can() at all, so its save button was always enabled
against a server requiring contract:sign; Capacity.tsx gated commitment
creation on deal:write/demand while the server wanted commitment:write/supply.

POST /api/activities was the one write bypassing executeMutation: no capability
check, and any member could mutate accounts.lastActivityAt as a side effect.
It is now a proper mutation() behind activity:write.

The shell becomes three panes — a collapsible shadcn sidebar with an account
switcher on the Piggy accent, a header with real search, and Piggy docked to
the right, page-aware and persistent across navigation. The phone keeps its
bottom tab bar, which is the thing this product already beat trycompai/crm on,
and gains the sidebar as a sheet.

Calendar is a projection over thirteen dated sources rather than a new table,
because a table would duplicate dates that already live on contracts, deals and
commitments and would drift — and one ledger answering the question is the
whole argument. It surfaces export_authorizations and compliance_artifacts,
which had indexed expires_at columns, schema comments saying they must be
alerted on, and no read endpoint or UI anywhere.

Learn carries two tracks. Concepts are members-only; the platform track can be
opened with a share code by someone with no account. The code mints a scoped
learn-only token and never a Principal — every route here resolves a principal
and then checks capabilities, so a principal-minting code would be one missing
check away from leaking the book. "Only platform-track rows may be code-visible"
is a database CHECK constraint as well as a write-path rule, and a test asserts
a valid learn token still gets 401 on /api/dashboard, /api/accounts and
/api/contracts — the same invariant scripts/deploy.sh refuses to ship without.

CD becomes tag-to-ship. CI publishes an image to the Gitea registry on a
release-* tag and cloud-2 pulls it, so no credential on the shared runner can
execute anything on production — by construction rather than by policy. Both
halves of deploy.sh's original rule survive: nothing on the runner reaches the
host, and a human still decides when it ships. deploy.sh gains a rollback and a
public-origin check, and PIG_IMAGE now reaches compose through `sudo env`,
without which sudo's env_reset silently resolved every release to pig:local.

Tests 141 -> 261.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-13 15:02:48 -07:00

148 lines
4.4 KiB
TypeScript

import { FACT_STATUSES } from '@pig/core';
import type { Fact, Database } from '@pig/db';
import { accounts, contacts, facts } from '@pig/db';
import { and, desc, eq } from 'drizzle-orm';
import { Hono } from 'hono';
import { z } from 'zod';
import {
apiError,
MutationError,
mutation,
type ApiEnv,
type MutationDefinition,
} from '../lib/mutation';
const factDecisionSchema = z
.object({
status: z.enum(FACT_STATUSES).refine(
(status): status is 'approved' | 'dismissed' =>
status === 'approved' || status === 'dismissed',
'A review may only approve or dismiss a proposed fact.',
),
})
.strict();
export interface FactDecisionResult {
fact: Fact;
/** Approval records a judgement; applying arbitrary field names is a separate safe system. */
recordUpdated: false;
}
function carriesEvidence(fact: Fact): boolean {
return Boolean(
fact.sourceUrl?.trim() ||
(fact.evidence && Object.keys(fact.evidence).length > 0),
);
}
/**
* Human approval accepts the evidence, not an untyped write to an arbitrary
* CRM field. Keeping those operations separate prevents a plausible claim
* such as `email` from silently overwriting a real person's record.
*/
export const factDecisionDefinition: MutationDefinition<
typeof factDecisionSchema,
FactDecisionResult
> = {
schema: factDecisionSchema,
// `fact:review`, not `data:import`. Accepting an agent's claim about a named
// person is a judgement about evidence; rewriting five thousand rows from a
// spreadsheet is not. They shared a capability until an audit noticed that
// granting either granted both.
permission: { capability: 'fact:review', team: 'research' },
invalidMessage: 'Invalid fact review decision.',
async mutate({ input, params, principal, tx, now }) {
const id = params.id;
if (!id) throw MutationError.notFound('Fact');
const [before] = await tx.select().from(facts).where(eq(facts.id, id)).limit(1);
if (!before) throw MutationError.notFound('Fact');
if (before.status !== 'proposed') {
throw new MutationError(
'fact_already_decided',
'Only a proposed fact can be reviewed.',
409,
);
}
if (input.status === 'approved' && !carriesEvidence(before)) {
throw new MutationError(
'missing_evidence',
'A fact needs a source or evidence before it can be approved.',
409,
);
}
const [updated] = await tx
.update(facts)
.set({
status: input.status,
decidedByUserId: principal.userId,
decidedAt: now,
})
.where(and(eq(facts.id, id), eq(facts.status, 'proposed')))
.returning();
if (!updated) {
throw new MutationError(
'fact_already_decided',
'This fact was reviewed by someone else.',
409,
);
}
const approved = input.status === 'approved';
return {
data: { fact: updated, recordUpdated: false },
activity: {
type: 'agent_action',
subject: `${approved ? 'Approved' : 'Dismissed'} proposed ${before.field}`,
body: approved
? 'Evidence approved; the CRM record remains unchanged until field-aware application is available.'
: 'Proposal dismissed; the CRM record was not changed.',
accountId: before.accountId ?? undefined,
contactId: before.contactId ?? undefined,
meta: {
factId: before.id,
decision: input.status,
field: before.field,
recordUpdated: false,
},
},
};
},
};
export function createFactsRoute(db: Database) {
const route = new Hono<ApiEnv>();
route.get('/api/facts', async (c) => {
const parsedStatus = z
.enum(FACT_STATUSES)
.safeParse(c.req.query('status') ?? 'proposed');
if (!parsedStatus.success) {
return c.json(
apiError('invalid_request', 'Unknown fact status.', parsedStatus.error.issues),
400,
);
}
const rows = await db
.select({
fact: facts,
accountName: accounts.name,
contactName: contacts.fullName,
})
.from(facts)
.leftJoin(accounts, eq(facts.accountId, accounts.id))
.leftJoin(contacts, eq(facts.contactId, contacts.id))
.where(eq(facts.status, parsedStatus.data))
.orderBy(desc(facts.observedAt))
.limit(200);
return c.json({ facts: rows });
});
route.patch('/api/facts/:id/decision', mutation(db, factDecisionDefinition));
return route;
}