2 Commits

Include renames

Author	SHA1	Message	Date
Metal AgentandClaude Opus 5	2aab0c4aab	Stop compiling the GPL crate GPUI drags in behind the framework ... Lumbridge is Apache-2.0, and decision 0023 quietly made it link GPL-3.0-or-later. `crates/gpui/Cargo.toml` at the pinned revision carries `ztracing.workspace = true` -- unconditional, not optional, not behind a feature -- and `ztracing` is GPL-3.0-or-later, as are the `zlog` and `ztracing_macro` it pulls. `sum_tree` asks for it too. The path is the ordinary Linux build, not an `--all-features` artefact and not a dev-dependency: lumbridge -> gpui_platform -> gpui_linux -> gpui -> ztracing -> zlog -> ztracing_macro `cargo deny check licenses` failed on it, exit 4. This is the second thing decision 0023 got wrong by reading the manifests of the crates it added instead of resolving the graph; the first was believing there were two Zed Git sources when there are five. Both were found by a gate that had never been run. There was no feature to turn off, so the choice was to relax the licence policy, drop the framework, or stop compiling the crate. `ztracing` is now redirected by a `[patch]` table at `crates/lumbridge-ztracing-shim`, a first-party zero-dependency no-op under Apache-2.0. `zlog` and `ztracing_macro` were reachable only through it and leave the lockfile with it. The shim is small because the usage is: nine `#[instrument(skip_all)]` sites across `gpui/src/svg_renderer.rs`, `sum_tree/src/sum_tree.rs` and `sum_tree/src/cursor.rs`, and nothing else. Upstream's own crate compiles to almost exactly this whenever the `ztracing` cfg is off, which is every build that is not a Tracy profiling build, so no shipping behaviour is lost. It is a proc-macro crate deliberately: such a crate can export nothing but proc macros, so an upstream revision that starts using `ztracing::Span` or `ztracing::info_span!` fails to compile and names the shim, rather than resolving to something plausible. `scripts/workspace-guard.sh` gained a third gate asserting, against Cargo.lock rather than the manifest, that no `ztracing`, `zlog` or `ztracing_macro` resolves to a Zed source and that the patch table is still present. `cargo deny` already checks this, and the duplication is the point: `scripts/ci.sh` downgrades a missing cargo-deny to a warning unless `LUMBRIDGE_CI_STRICT=1`, and that is how the licence closure went ungated once already. A `[patch]` is an unusually quiet thing to lose -- delete the table and everything still compiles, still passes, and is GPL again. Removing the three GPL rejections exposed a fourth that had been sitting beside them and was never reported separately: `libbz2-rs-sys` under `bzip2-1.0.6`, reached through async-compression <- http_client <- gpui. It is BSD-style and permissive with no copyleft, and is allowed in `deny.toml` with that reasoning written down. `cargo deny check licenses sources` is exit 0 for the first time. The Git-source allowances in `deny.toml` are all still needed; the patched crate's own source was `zed.git`, which `gpui` still requires. Decision 0025 records the whole of it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SPYebLiN2w4TqnHUYGdECq	2026-09-01 14:02:59 -07:00
Metal AgentandClaude Opus 5	9a29e8e335	Make the gate structural, and correct what it tells an agent ... Three gates in this repository were decorative, and each was discovered by being wrong rather than by failing. A crate directory in neither members nor exclude is silently not built, which is how lumbridge-devices shipped 1,127 lines that had never compiled. scripts/workspace-guard.sh refuses that state, and asserts the gpui source and version out of Cargo.lock rather than the manifest, because a manifest states an intent while the lockfile states what would actually be compiled -- and a caret requirement accepts a version nobody reviewed. It needs no compiler, so it runs first and in the headless job, which unlike the UI job is not continue-on-error and can therefore actually fail a push. deny.toml's source policy had never been executed: ci.sh ran `check licenses` alone, and `check sources` failed immediately on the rev-pinned buzz-sdk. The permitted Git sources are now named one by one and the check runs, so a fourth is a decision rather than an accident. cargo-deny and cargo-nextest being absent was a warning that let a run report green having skipped the licence gate DISTRIBUTION.md depends on. Under LUMBRIDGE_CI_STRICT=1 a missing tool now fails; locally it stays a warning so a contributor is not blocked. skills/lumbridge-development/SKILL.md told every agent that GPUI and Floem live in spikes/ and that no framework may be selected until both pass the hard gates. Decision 0017 settled that a month ago in the opposite direction. The entry point an agent is meant to read was the least accurate document in the repository. Decision 0023 records where the GPUI dependency actually goes. Published gpui has not been released since 2025-10-22, Zed's main still declares 0.2.2 with no bump pending, the platform backends moved to crates that inherit publish = false, gpui's own x11 and wayland features are now empty markers, and 0.2.2 has no accesskit dependency at all -- so "published now, migrate later" was never available. The adapter 0017 promised was never written and the call sites grew from few to 147 against 20 identities, so the adapter is written first, on 0.2.2, before the dependency moves. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SPYebLiN2w4TqnHUYGdECq	2026-09-01 12:51:25 -07:00