`cargo clippy -p lumbridge -- -D warnings` has been failing: LumbridgeShell::new
was 104 lines against a pedantic limit of 100. It stayed invisible because
three separate things were each enough to hide it. The rust-ui job is
continue-on-error and so cannot fail a push; the job had never run at all,
since the split that created it was never pushed; and every historical green
run predates the shell leaving spikes/, where the workspace excluded it.
`./scripts/ci.sh --ui` reproduces it in seconds on any machine.
The fix is not an allow. `new` was doing four unrelated things, and the two
detached poll loops in the middle of it were the reason nobody could see the
constructor. They become named functions that say what they are for:
drive_synthetic_surfaces animates the comparison fixture the framework
benchmark is measured against, poll_runtime_events drains real PTY output on
its own interval and repaints only when something arrived, and
launch_restored_terminals gives every restored panel a runtime actor while
keeping -- not dropping -- one whose session failed to start, because decision
0011 makes a panel identity durable and a saved pane vanishing with no
explanation is worse than a pane carrying its fault.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SPYebLiN2w4TqnHUYGdECq
