Metal AgentandClaude Opus 5
2aab0c4aab
Lumbridge is Apache-2.0, and decision 0023 quietly made it link
GPL-3.0-or-later. `crates/gpui/Cargo.toml` at the pinned revision carries
`ztracing.workspace = true` -- unconditional, not optional, not behind a
feature -- and `ztracing` is GPL-3.0-or-later, as are the `zlog` and
`ztracing_macro` it pulls. `sum_tree` asks for it too. The path is the ordinary
Linux build, not an `--all-features` artefact and not a dev-dependency:
lumbridge -> gpui_platform -> gpui_linux -> gpui -> ztracing -> zlog
-> ztracing_macro
`cargo deny check licenses` failed on it, exit 4.
This is the second thing decision 0023 got wrong by reading the manifests of the
crates it added instead of resolving the graph; the first was believing there
were two Zed Git sources when there are five. Both were found by a gate that had
never been run.
There was no feature to turn off, so the choice was to relax the licence policy,
drop the framework, or stop compiling the crate. `ztracing` is now redirected by
a `[patch]` table at `crates/lumbridge-ztracing-shim`, a first-party
zero-dependency no-op under Apache-2.0. `zlog` and `ztracing_macro` were
reachable only through it and leave the lockfile with it.
The shim is small because the usage is: nine `#[instrument(skip_all)]` sites
across `gpui/src/svg_renderer.rs`, `sum_tree/src/sum_tree.rs` and
`sum_tree/src/cursor.rs`, and nothing else. Upstream's own crate compiles to
almost exactly this whenever the `ztracing` cfg is off, which is every build
that is not a Tracy profiling build, so no shipping behaviour is lost. It is a
proc-macro crate deliberately: such a crate can export nothing but proc macros,
so an upstream revision that starts using `ztracing::Span` or
`ztracing::info_span!` fails to compile and names the shim, rather than
resolving to something plausible.
`scripts/workspace-guard.sh` gained a third gate asserting, against Cargo.lock
rather than the manifest, that no `ztracing`, `zlog` or `ztracing_macro`
resolves to a Zed source and that the patch table is still present. `cargo deny`
already checks this, and the duplication is the point: `scripts/ci.sh`
downgrades a missing cargo-deny to a warning unless `LUMBRIDGE_CI_STRICT=1`, and
that is how the licence closure went ungated once already. A `[patch]` is an
unusually quiet thing to lose -- delete the table and everything still compiles,
still passes, and is GPL again.
Removing the three GPL rejections exposed a fourth that had been sitting beside
them and was never reported separately: `libbz2-rs-sys` under `bzip2-1.0.6`,
reached through async-compression <- http_client <- gpui. It is BSD-style and
permissive with no copyleft, and is allowed in `deny.toml` with that reasoning
written down. `cargo deny check licenses sources` is exit 0 for the first time.
The Git-source allowances in `deny.toml` are all still needed; the patched
crate's own source was `zed.git`, which `gpui` still requires.
Decision 0025 records the whole of it.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SPYebLiN2w4TqnHUYGdECq
35 lines
1.4 KiB
TOML
35 lines
1.4 KiB
TOML
# This package is deliberately named `ztracing` and not `lumbridge-ztracing-shim`.
|
|
#
|
|
# A `[patch]` entry can only replace a package with one of the SAME NAME, so the
|
|
# name is load-bearing: the root manifest's
|
|
# `[patch."https://github.com/zed-industries/zed.git"]` table redirects the
|
|
# `ztracing` that `gpui` and `sum_tree` ask for at this directory, and Cargo
|
|
# matches the two by package name. The directory keeps the `lumbridge-` prefix
|
|
# every other crate here has so that a reader browsing `crates/` can see whose
|
|
# code it is; `src/lib.rs` explains why the package underneath answers to a
|
|
# different name.
|
|
[package]
|
|
name = "ztracing"
|
|
description = "A no-op stand-in for Zed's GPL-licensed ztracing, so Lumbridge's build graph stays Apache-2.0"
|
|
version = "0.1.0"
|
|
edition.workspace = true
|
|
rust-version.workspace = true
|
|
license.workspace = true
|
|
repository.workspace = true
|
|
publish = false
|
|
|
|
# A proc-macro crate, because the only symbol the graph reaches for is an
|
|
# attribute macro. Nothing else can live in a crate declared this way, which is
|
|
# the point: an upstream revision that starts using `ztracing::Span` or
|
|
# `ztracing::info_span!` fails to compile here rather than quietly resolving.
|
|
[lib]
|
|
proc-macro = true
|
|
|
|
# No dependencies. `syn` and `quote` would only be needed to parse an item this
|
|
# macro then reassembles unchanged; returning the input `TokenStream` untouched
|
|
# is both correct and three crates cheaper.
|
|
[dependencies]
|
|
|
|
[lints]
|
|
workspace = true
|