lumbridge-public/tera

Archived

Fork 0

Commit Graph

Author	SHA1	Message	Date
karti	51979feea0	Shadows land on the building, and the sky layers stop repeating themselves Shadows were the right size and pointed at nothing. Last round fixed the missing `updateProjectionMatrix()`, so the frustum finally became the size every caller asks for — but nothing aimed it, and `sun.target` sits at the world origin. A pack's origin is the north-west corner of its slab, so for lumbridge-hq the box was off-centre by half the building: 14.4 m of a 48 m plate, about a third of the floor, fell outside the frustum and neither cast nor received. Invisible while three's broken ±5 default made shadows useless everywhere; obvious the moment they started working. `SceneKitOptions` takes a `shadowTarget` now, both callers pass one, and the light's target is added to the scene — which is the part that actually matters, because `LightShadow.updateMatrices` reads `target.matrixWorld` and an unparented `Object3D` is never reached by the traversal that updates it. The sun is also placed relative to the target rather than the origin, so light-to-target is exactly `sunDistance` for every direction, which is the invariant each caller's `shadowNear`/`shadowFar` were chosen against. `flights.ts` could not be tested, and that is why it was untested. It used a TypeScript parameter property — the one piece of TS syntax that emits code rather than annotating a type — so Node's type stripping refused the whole module. The bundler never cared, so nobody found out until the first `node --test` file tried to import it. The module carrying the worst bug this project has shipped was, by construction, the one module that could not have a test. It has eleven now, including one that fails if the live-aircraft repeat-skip is removed. Robots are on the plan panel — a turned marker with a bow for heading, in the one hue left that is neither the people-blue nor the camera-amber. Review findings cleared across the four new sky/robot modules: a real 24 mm void at the ankle and an 8 mm hole through each forearm, a per-frame allocation in the robot heading picker, a per-frame sort in the starlink ranking, `uTime` growing unbounded until the cloud breath quantises, and `DAY_REFERENCE`'s derivation which did not reproduce. `createStarlinkMeshLayer` now takes a board radius — the same unit its sibling takes — instead of a dome radius with nothing in the types to tell them apart. That is the exact confusion that has already caused one real bug here. `DOME_RADIUS_FACTOR` has one owner and is imported, not copied: the points and the meshes must be on the same dome or a satellite that grows geometry also jumps. Several comments were wrong rather than merely stale — a fabricated claim about `Object3D.clone`, a fabricated attribution to `Plan`, an inverted `DoubleSide` argument, a triangle ledger citing a function that no longer exists, and a defensive-call rationale that contradicted the paragraph above it. In a codebase where the comments are the design record, those are defects. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-07 02:50:25 -07:00
karti	af0d4a7d57	The office keeps its lights on, and something walks around under them Lights. A sited office follows the real sun, and the real sun spends half its time below the horizon — which was producing a technically correct and completely useless picture: an unlit floor plate at midnight in a building whose whole premise is that you can see who is at which desk. `luminaires.ts` brings the diffusers up as the sun goes down and reports one scalar for how much interior light there is; `withHouseLights` adds it to the rig. CONTRACT §4's rule that a fitting emits no light is kept in full — nothing here is a light source, and the rig still has one owner. And they notice you. A fitting within four metres of somebody walking underneath brightens and fades back as they leave, which is what an occupancy-sensed floor actually does at night. They are one `InstancedMesh` sharing one material, so `emissiveIntensity` cannot vary between them — `instanceColor` can, but three multiplies it into the diffuse term only, so six lines of `onBeforeCompile` carry it into the emissive term as well. The alternative was one mesh per fitting: forty draw calls of ceiling in a building that spends about twenty on everything. Optimus. A posable Gen-3 humanoid — eleven articulating joints, pale shells over a dark frame, a black visor — with a walk cycle driven by distance travelled rather than wall-clock, so the feet do not slide when a robot slows down. Two per floor, derived from the pack's levels, so the two-storey tower gets four and the hangar gets two without either pack knowing robots exist. They wander between reachable points using `Plan.blocked` — the collider the wall split already produces — and they are deliberately not gated on `depth`: the build-time-exclusion rule is about occupancy, and a robot is nobody. Starlinks stop being pixels. The sixty-four nearest the centre of view grow real geometry — a flat bus with ONE large solar array, which is the actual signature and the thing everybody draws symmetrically and wrong — fading in so there is no pop where a point becomes a mesh. Two draw calls. The sun for their attitude comes from `solar.ts` and not from the rig, because `atmosphere.ts` floors the light direction to keep the shadow camera usable, and a sun ten degrees down is exactly the dusk geometry that makes a pass visible. Aircraft are airliners now — swept wings, nacelles, a fin — instead of an arrowhead, still one shared geometry facing +Z as `flights.ts` requires. Clouds drift over the board, driven by observed cover, lit by the rig rather than by themselves. Four modules were built by subagents and reviewed by another; every one came back `needs-work` and the reviews were right. Fixed before wiring: - The walk cycle's arms were a quarter cycle out of step with its legs — the legs are cosine-shaped and the arms were on `sin`, so at the instant the left leg reached full forward the left shoulder was at dead neutral. Uncanny, and hard to name until it is pointed at. - Every Optimus shell used a `roundedBox` radius of 0.12–0.22, which that primitive turns into a near-circular cross-section — the figure was built out of lozenges, not panels. The rest of the library uses 0.02–0.09. - The cloud material was `transparent` + `DoubleSide` without `forceSinglePass`, so three rendered it twice per frame and bumped `material.version` on each pass — rebuilding the program cache key forever, on the one layer that is fill-rate bound. - `starlinkMesh.dispose()` freed the geometries but not the `InstancedMesh`es, orphaning their instance buffers on every city switch. - The airliner's tailplane roots sat outside the tail cone and hung in free air over most of their chord. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-07 00:56:49 -07:00

Author

SHA1

Message

Date

karti

51979feea0

Shadows land on the building, and the sky layers stop repeating themselves

**Shadows were the right size and pointed at nothing.** Last round fixed the
missing `updateProjectionMatrix()`, so the frustum finally became the size
every caller asks for — but nothing aimed it, and `sun.target` sits at the
world origin. A pack's origin is the **north-west corner of its slab**, so
for lumbridge-hq the box was off-centre by half the building: 14.4 m of a
48 m plate, about a third of the floor, fell outside the frustum and
neither cast nor received. Invisible while three's broken ±5 default made
shadows useless everywhere; obvious the moment they started working.

`SceneKitOptions` takes a `shadowTarget` now, both callers pass one, and
the light's target is added to the scene — which is the part that actually
matters, because `LightShadow.updateMatrices` reads `target.matrixWorld`
and an unparented `Object3D` is never reached by the traversal that
updates it. The sun is also placed relative to the target rather than the
origin, so light-to-target is exactly `sunDistance` for every direction,
which is the invariant each caller's `shadowNear`/`shadowFar` were chosen
against.

**`flights.ts` could not be tested, and that is why it was untested.** It
used a TypeScript parameter property — the one piece of TS syntax that
*emits code* rather than annotating a type — so Node's type stripping
refused the whole module. The bundler never cared, so nobody found out
until the first `node --test` file tried to import it. The module carrying
the worst bug this project has shipped was, by construction, the one
module that could not have a test. It has eleven now, including one that
fails if the live-aircraft repeat-skip is removed.

**Robots are on the plan panel** — a turned marker with a bow for heading,
in the one hue left that is neither the people-blue nor the camera-amber.

Review findings cleared across the four new sky/robot modules: a real
24 mm void at the ankle and an 8 mm hole through each forearm, a
per-frame allocation in the robot heading picker, a per-frame sort in the
starlink ranking, `uTime` growing unbounded until the cloud breath
quantises, and `DAY_REFERENCE`'s derivation which did not reproduce.

`createStarlinkMeshLayer` now takes a **board** radius — the same unit its
sibling takes — instead of a dome radius with nothing in the types to tell
them apart. That is the exact confusion that has already caused one real
bug here. `DOME_RADIUS_FACTOR` has one owner and is imported, not copied:
the points and the meshes must be on the same dome or a satellite that
grows geometry also jumps.

Several comments were wrong rather than merely stale — a fabricated claim
about `Object3D.clone`, a fabricated attribution to `Plan`, an inverted
`DoubleSide` argument, a triangle ledger citing a function that no longer
exists, and a defensive-call rationale that contradicted the paragraph
above it. In a codebase where the comments are the design record, those
are defects.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

2026-08-07 02:50:25 -07:00

karti

af0d4a7d57

The office keeps its lights on, and something walks around under them

**Lights.** A sited office follows the real sun, and the real sun spends
half its time below the horizon — which was producing a technically
correct and completely useless picture: an unlit floor plate at midnight
in a building whose whole premise is that you can see who is at which
desk. `luminaires.ts` brings the diffusers up as the sun goes down and
reports one scalar for how much interior light there is; `withHouseLights`
adds it to the rig. CONTRACT §4's rule that a fitting emits no light is
kept in full — nothing here is a light source, and the rig still has one
owner.

**And they notice you.** A fitting within four metres of somebody walking
underneath brightens and fades back as they leave, which is what an
occupancy-sensed floor actually does at night. They are one `InstancedMesh`
sharing one material, so `emissiveIntensity` cannot vary between them —
`instanceColor` can, but three multiplies it into the diffuse term only, so
six lines of `onBeforeCompile` carry it into the emissive term as well. The
alternative was one mesh per fitting: forty draw calls of ceiling in a
building that spends about twenty on everything.

**Optimus.** A posable Gen-3 humanoid — eleven articulating joints, pale
shells over a dark frame, a black visor — with a walk cycle driven by
*distance travelled* rather than wall-clock, so the feet do not slide when
a robot slows down. Two per floor, derived from the pack's levels, so the
two-storey tower gets four and the hangar gets two without either pack
knowing robots exist. They wander between reachable points using
`Plan.blocked` — the collider the wall split already produces — and they
are deliberately **not** gated on `depth`: the build-time-exclusion rule is
about occupancy, and a robot is nobody.

**Starlinks stop being pixels.** The sixty-four nearest the centre of view
grow real geometry — a flat bus with ONE large solar array, which is the
actual signature and the thing everybody draws symmetrically and wrong —
fading in so there is no pop where a point becomes a mesh. Two draw calls.
The sun for their attitude comes from `solar.ts` and not from the rig,
because `atmosphere.ts` floors the light direction to keep the shadow
camera usable, and a sun ten degrees *down* is exactly the dusk geometry
that makes a pass visible.

**Aircraft** are airliners now — swept wings, nacelles, a fin — instead of
an arrowhead, still one shared geometry facing +Z as `flights.ts` requires.
**Clouds** drift over the board, driven by observed cover, lit by the rig
rather than by themselves.

Four modules were built by subagents and reviewed by another; every one
came back `needs-work` and the reviews were right. Fixed before wiring:

  - The walk cycle's arms were a quarter cycle out of step with its legs —
    the legs are cosine-shaped and the arms were on `sin`, so at the
    instant the left leg reached full forward the left shoulder was at dead
    neutral. Uncanny, and hard to name until it is pointed at.
  - Every Optimus shell used a `roundedBox` radius of 0.12–0.22, which that
    primitive turns into a near-circular cross-section — the figure was
    built out of lozenges, not panels. The rest of the library uses
    0.02–0.09.
  - The cloud material was `transparent` + `DoubleSide` without
    `forceSinglePass`, so three rendered it twice per frame *and* bumped
    `material.version` on each pass — rebuilding the program cache key
    forever, on the one layer that is fill-rate bound.
  - `starlinkMesh.dispose()` freed the geometries but not the
    `InstancedMesh`es, orphaning their instance buffers on every city
    switch.
  - The airliner's tailplane roots sat outside the tail cone and hung in
    free air over most of their chord.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

2026-08-07 00:56:49 -07:00

2 Commits