13dec6b4b8
Seven parallel agents and an adversarial verification pass. The three things worth knowing before reading the diff: RBAC WAS ALREADY BUILT. docs/build-plan.md marks F2 and F3 outstanding and is stale — packages/core/src/permissions.ts and lib/mutation.ts shipped long ago. So this does not rebuild them; it closes the gaps an audit found. The big one is that reads were entirely ungoverned: every GET was "any authenticated member", so a junior demand rep and a research contractor could both pull per-block supplier cost and break-even prices from /api/capacity/margin, and every contract's negotiated terms. For a company whose margin is the business, that was the hole that mattered. Adds book:read / economics:read / team:read, a readGuard middleware, and a `viewer` role below member. THE BUTTON AND THE 403 DISAGREED — the exact thing F3 said must never happen. Contracts.tsx never called can() at all, so its save button was always enabled against a server requiring contract:sign; Capacity.tsx gated commitment creation on deal:write/demand while the server wanted commitment:write/supply. POST /api/activities was the one write bypassing executeMutation: no capability check, and any member could mutate accounts.lastActivityAt as a side effect. It is now a proper mutation() behind activity:write. The shell becomes three panes — a collapsible shadcn sidebar with an account switcher on the Piggy accent, a header with real search, and Piggy docked to the right, page-aware and persistent across navigation. The phone keeps its bottom tab bar, which is the thing this product already beat trycompai/crm on, and gains the sidebar as a sheet. Calendar is a projection over thirteen dated sources rather than a new table, because a table would duplicate dates that already live on contracts, deals and commitments and would drift — and one ledger answering the question is the whole argument. It surfaces export_authorizations and compliance_artifacts, which had indexed expires_at columns, schema comments saying they must be alerted on, and no read endpoint or UI anywhere. Learn carries two tracks. Concepts are members-only; the platform track can be opened with a share code by someone with no account. The code mints a scoped learn-only token and never a Principal — every route here resolves a principal and then checks capabilities, so a principal-minting code would be one missing check away from leaking the book. "Only platform-track rows may be code-visible" is a database CHECK constraint as well as a write-path rule, and a test asserts a valid learn token still gets 401 on /api/dashboard, /api/accounts and /api/contracts — the same invariant scripts/deploy.sh refuses to ship without. CD becomes tag-to-ship. CI publishes an image to the Gitea registry on a release-* tag and cloud-2 pulls it, so no credential on the shared runner can execute anything on production — by construction rather than by policy. Both halves of deploy.sh's original rule survive: nothing on the runner reaches the host, and a human still decides when it ships. deploy.sh gains a rollback and a public-origin check, and PIG_IMAGE now reaches compose through `sudo env`, without which sudo's env_reset silently resolved every release to pig:local. Tests 141 -> 261. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
156 lines
5.0 KiB
TypeScript
156 lines
5.0 KiB
TypeScript
import { timingSafeEqual } from 'node:crypto';
|
|
import { createServer, type IncomingMessage, type Server, type ServerResponse } from 'node:http';
|
|
import { z } from 'zod';
|
|
import { PIGGY_PAGE_ROUTES, PIGGY_RECORD_TYPES } from '@pig/core';
|
|
import type { Database } from '@pig/db';
|
|
import {
|
|
PrimeOpenAIChatProvider,
|
|
type PiggyChatEvent,
|
|
type PiggyChatRequest,
|
|
} from './chat';
|
|
import { createInteractivePigTools } from './chat-tools';
|
|
|
|
/**
|
|
* Derived from the @pig/core tuples rather than retyped, because this schema
|
|
* is `.strict()` and so is the relay's: a context shape one of them has not
|
|
* been told about is a 400, not a degraded answer. `route` is a closed set
|
|
* because a docked panel publishes it on every navigation, and free text there
|
|
* would put arbitrary client strings into a model prompt on every page change.
|
|
*/
|
|
const contextSchema = z.discriminatedUnion('type', [
|
|
z
|
|
.object({
|
|
type: z.enum(PIGGY_RECORD_TYPES),
|
|
id: z.string().uuid(),
|
|
label: z.string().max(240).optional(),
|
|
})
|
|
.strict(),
|
|
z
|
|
.object({
|
|
type: z.literal('page'),
|
|
route: z.enum(PIGGY_PAGE_ROUTES),
|
|
label: z.string().max(240).optional(),
|
|
})
|
|
.strict(),
|
|
]);
|
|
|
|
export const piggyChatRequestSchema = z
|
|
.object({
|
|
principalUserId: z.string().uuid(),
|
|
message: z.string().trim().min(1).max(4_000),
|
|
history: z
|
|
.array(
|
|
z.object({
|
|
role: z.enum(['user', 'assistant']),
|
|
content: z.string().min(1).max(8_000),
|
|
}),
|
|
)
|
|
.max(20)
|
|
.optional(),
|
|
context: contextSchema.optional(),
|
|
})
|
|
.strict();
|
|
|
|
interface ChatRunner {
|
|
readonly model: string;
|
|
run(request: PiggyChatRequest): AsyncIterable<PiggyChatEvent>;
|
|
}
|
|
|
|
export interface PiggyChatServerOptions {
|
|
host?: string;
|
|
port: number;
|
|
internalToken: string;
|
|
provider: ChatRunner;
|
|
allowNonLoopback?: boolean;
|
|
}
|
|
|
|
export function startPiggyChatServer(
|
|
db: Database,
|
|
options: PiggyChatServerOptions,
|
|
): Server {
|
|
const host = options.host ?? '127.0.0.1';
|
|
if (!isLoopback(host) && !options.allowNonLoopback) {
|
|
throw new Error('Piggy chat must bind to loopback; expose it only through the authenticated CRM API.');
|
|
}
|
|
if (options.internalToken.length < 32) {
|
|
throw new Error('PIGGY_INTERNAL_TOKEN must contain at least 32 characters.');
|
|
}
|
|
|
|
const server = createServer(async (request, response) => {
|
|
if (request.method !== 'POST' || request.url !== '/internal/chat') {
|
|
response.writeHead(404).end();
|
|
return;
|
|
}
|
|
if (!tokenMatches(request.headers.authorization, options.internalToken)) {
|
|
response.writeHead(401, { 'content-type': 'application/json' });
|
|
response.end(JSON.stringify({ error: 'Unauthorised internal request.' }));
|
|
return;
|
|
}
|
|
|
|
try {
|
|
const body = piggyChatRequestSchema.parse(JSON.parse(await readBoundedBody(request, 32_768)));
|
|
const abort = new AbortController();
|
|
response.on('close', () => abort.abort());
|
|
response.writeHead(200, {
|
|
'content-type': 'application/x-ndjson; charset=utf-8',
|
|
'cache-control': 'no-cache, no-transform',
|
|
'x-content-type-options': 'nosniff',
|
|
});
|
|
|
|
for await (const event of options.provider.run({
|
|
message: body.message,
|
|
history: body.history,
|
|
context: body.context,
|
|
tools: createInteractivePigTools(db, body.context),
|
|
signal: abort.signal,
|
|
})) {
|
|
response.write(`${JSON.stringify(event)}\n`);
|
|
}
|
|
response.end();
|
|
} catch (error) {
|
|
const invalidRequest = error instanceof z.ZodError;
|
|
const message = invalidRequest ? 'Invalid Piggy chat request.' : 'Piggy chat failed.';
|
|
if (!response.headersSent) {
|
|
response.writeHead(invalidRequest ? 400 : 500, {
|
|
'content-type': 'application/json',
|
|
});
|
|
response.end(JSON.stringify({ error: message }));
|
|
return;
|
|
}
|
|
response.end(`${JSON.stringify({ type: 'error', message })}\n`);
|
|
}
|
|
});
|
|
server.listen(options.port, host);
|
|
return server;
|
|
}
|
|
|
|
export function createPrimeChatProvider(options: ConstructorParameters<typeof PrimeOpenAIChatProvider>[0]) {
|
|
return new PrimeOpenAIChatProvider(options);
|
|
}
|
|
|
|
function tokenMatches(header: string | undefined, expected: string): boolean {
|
|
const supplied = header?.startsWith('Bearer ') ? header.slice(7) : '';
|
|
const suppliedBytes = Buffer.from(supplied);
|
|
const expectedBytes = Buffer.from(expected);
|
|
return (
|
|
suppliedBytes.length === expectedBytes.length &&
|
|
timingSafeEqual(suppliedBytes, expectedBytes)
|
|
);
|
|
}
|
|
|
|
async function readBoundedBody(request: IncomingMessage, maximumBytes: number): Promise<string> {
|
|
const chunks: Buffer[] = [];
|
|
let size = 0;
|
|
for await (const chunk of request) {
|
|
const bytes = Buffer.isBuffer(chunk) ? chunk : Buffer.from(chunk);
|
|
size += bytes.length;
|
|
if (size > maximumBytes) throw new Error('Piggy chat request is too large.');
|
|
chunks.push(bytes);
|
|
}
|
|
return Buffer.concat(chunks).toString('utf8');
|
|
}
|
|
|
|
function isLoopback(host: string): boolean {
|
|
return host === '127.0.0.1' || host === '::1' || host === 'localhost';
|
|
}
|