Metal AgentandClaude Opus 5
316fa32745
The product was spikes/gpui-shell: a cargo workspace of its own, named in the root manifest's exclude list. It inherited neither unsafe_code = "forbid" nor clippy pedantic, and ./scripts/ci.sh never compiled it. Every test written into it silently never ran, and apps/lumbridge was an eleven-line stub printing a version string. Four separate research passes over the sidebar, settings, devices, and theme work independently discovered they were about to write substantial new code into that directory. Graduating first means writing it once. - apps/lumbridge is the product; spikes/ui-shell-model becomes crates/lumbridge-ui-fixture and joins the workspace. - scripts/ci.sh takes --headless and --ui. The headless pass excludes the two UI crates by name, so a contributor changing lumbridge-core does not wait on a window toolkit, and a runner that cannot carry GPUI still gates everything else. A new crate is headless by default rather than silently joining the slow job. - scripts/native-libs.sh replaces the ad-hoc symlink in the launcher, and says which apt package actually fixes the problem instead of working around it silently. The stale libxcb/libxkbcommon symlinks in the old spike target directory are gone; only libxkbcommon-x11.so was ever needed. - deny.toml and cargo deny check licenses. spikes/README.md called GPUI's licence closure a hard gate and the scorecard scored it pending; graduation makes it the product's closure, so it is enforced rather than described. Two rejections were reviewed and allowed with the reasoning recorded in the file: webpki-roots under CDLA-Permissive-2.0 (Mozilla's CA store, data not code, reached through ureq) and libfuzzer-sys under NCSA (reached only under all-features via gpui's image decoder; no shipped build links it). Clippy pedantic across both crates is clean at -D warnings. render was 353 lines; render_sidebar, render_tabs, and render_root come out of it, which the sidebar rework needed anyway. The remaining over-length functions are single declarative element trees and carry per-function allows with reasons, not a blanket suppression. Decision 0017 records the two calls this forces: published gpui 0.2.2 behind an accessibility adapter rather than an unpinned Zed revision and an MSRV bump, and Floem frozen rather than maintained in parity or deleted. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
30 lines
1.1 KiB
Bash
Executable File
30 lines
1.1 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Makes GPUI's X11 backend linkable on distributions that ship
|
|
# libxkbcommon-x11.so.0 without the unversioned development symlink.
|
|
#
|
|
# The real fix is installing libxkbcommon-x11-dev. When that package is absent
|
|
# this creates the one symlink the linker needs in a cache directory and exports
|
|
# LIBRARY_PATH, so a UI build works without root. Source it, do not run it.
|
|
#
|
|
# source scripts/native-libs.sh
|
|
|
|
lumbridge_native_libs() {
|
|
local runtime=/usr/lib/x86_64-linux-gnu/libxkbcommon-x11.so.0
|
|
local devlink=/usr/lib/x86_64-linux-gnu/libxkbcommon-x11.so
|
|
if [ -e "$devlink" ]; then
|
|
return 0
|
|
fi
|
|
if [ ! -e "$runtime" ]; then
|
|
echo "libxkbcommon-x11 is not installed; a UI build will fail to link" >&2
|
|
echo " install it with: sudo apt install libxkbcommon-x11-dev" >&2
|
|
return 0
|
|
fi
|
|
local cache="${XDG_CACHE_HOME:-$HOME/.cache}/lumbridge-native-libs"
|
|
mkdir -p "$cache"
|
|
ln -sfn "$runtime" "$cache/libxkbcommon-x11.so"
|
|
export LIBRARY_PATH="$cache${LIBRARY_PATH:+:$LIBRARY_PATH}"
|
|
echo "using $cache for libxkbcommon-x11.so (install libxkbcommon-x11-dev to avoid this)" >&2
|
|
}
|
|
|
|
lumbridge_native_libs
|